Browse Source

Add an initialization case to node_get_prim_dirport

Fixes a bug found by scan-build; bugfix on c2fa743806acc. Bug not in
any released Tor.
Nick Mathewson 6 years ago
parent
commit
1abe0a5769
1 changed files with 5 additions and 0 deletions
  1. 5 0
      src/or/nodelist.c

+ 5 - 0
src/or/nodelist.c

@@ -1583,6 +1583,11 @@ node_get_prim_dirport(const node_t *node, tor_addr_port_t *ap_out)
   node_assert_ok(node);
   tor_assert(ap_out);
 
+  /* Clear the address, as a safety precaution if calling functions ignore the
+   * return value */
+  tor_addr_make_null(&ap_out->addr, AF_INET);
+  ap_out->port = 0;
+
   /* Check ri first, because rewrite_node_address_for_bridge() updates
    * node->ri with the configured bridge address. */