Browse Source

rng_test_helpers: add a needless lock/unlock pair to please coverity

Fix for CID 1444908
Nick Mathewson 5 years ago
parent
commit
1bf451cffb
1 changed files with 3 additions and 0 deletions
  1. 3 0
      src/test/rng_test_helpers.c

+ 3 - 0
src/test/rng_test_helpers.c

@@ -183,11 +183,14 @@ void
 testing_enable_prefilled_rng(const void *buffer, size_t buflen)
 {
   tor_assert(buflen > 0);
+  tor_assert(!rng_mutex);
   rng_mutex = tor_mutex_new();
 
+  tor_mutex_acquire(rng_mutex);
   prefilled_rng_buffer = tor_memdup(buffer, buflen);
   prefilled_rng_buflen = buflen;
   prefilled_rng_idx = 0;
+  tor_mutex_release(rng_mutex);
 
   MOCK(crypto_rand, crypto_rand_prefilled);
   MOCK(crypto_strongest_rand_, mock_crypto_strongest_rand);