Bläddra i källkod

Fix memory leak in disk_state_parse_commits().

This patch fixes a memory leak in disk_state_parse_commits() where if
commit is NULL, we continue the internal loop, but without ever freeing
the args variable.

See: Coverity CID 1437441.
Alexander Færøy 6 år sedan
förälder
incheckning
3395de51a0
1 ändrade filer med 1 tillägg och 0 borttagningar
  1. 1 0
      src/or/shared_random_state.c

+ 1 - 0
src/or/shared_random_state.c

@@ -409,6 +409,7 @@ disk_state_parse_commits(sr_state_t *state,
     if (commit == NULL) {
       /* Ignore badly formed commit. It could also be a authority
        * fingerprint that we don't know about so it shouldn't be used. */
+      smartlist_free(args);
       continue;
     }
     /* We consider parseable commit from our disk state to be valid because