Bläddra i källkod

Improve #include counting func and move it to metrics.py.

George Kadianakis 5 år sedan
förälder
incheckning
371ea65c08
2 ändrade filer med 9 tillägg och 4 borttagningar
  1. 8 0
      scripts/maint/practracker/metrics.py
  2. 1 4
      scripts/maint/practracker/practracker.py

+ 8 - 0
scripts/maint/practracker/metrics.py

@@ -8,6 +8,14 @@ def file_len(f):
         pass
     return i + 1
 
+def get_include_count(f):
+    """Get number of #include statements in the file"""
+    include_count = 0
+    for line in f:
+        if re.match(r' *# *include', line):
+            include_count += 1
+    return include_count
+
 def function_lines(f):
     """
     Return iterator which iterates over functions and returns (function name, function lines)

+ 1 - 4
scripts/maint/practracker/practracker.py

@@ -57,10 +57,7 @@ def consider_file_size(fname, f, exceptions_str):
         print_violation_if_not_exception(violation_str, exceptions_str)
 
 def consider_includes(fname, f, exceptions_str):
-    include_count = 0
-    for _, line in enumerate(f):
-        if line.startswith("#include "):
-            include_count += 1
+    include_count = metrics.get_include_count(f)
 
     if include_count > MAX_INCLUDE_COUNT:
         violation_str = "violation include-count %s %d" % (fname, include_count)