Преглед на файлове

Resolve issues in changes files

Nick Mathewson преди 9 години
родител
ревизия
441a481bb8
променени са 8 файла, в които са добавени 21 реда и са изтрити 17 реда
  1. 2 1
      changes/bug13936
  2. 2 1
      changes/bug13942
  3. 1 1
      changes/bug14001-clang-warning
  4. 2 2
      changes/bug14002-osx-transproxy-ipfw-pf
  5. 1 1
      changes/bug7803
  6. 6 8
      changes/spurious-clang-warnings
  7. 1 0
      changes/ticket-11291
  8. 6 3
      scripts/maint/lintChanges.py

+ 2 - 1
changes/bug13936

@@ -3,4 +3,5 @@
       when a rendezvous circuit is opened because circuit_has_opened() jobs
       is to call a specialized function depending on the circuit purpose.
       Furthermore, a controller event will be triggered here where the
-      former did not.
+      former did not. Fixes bug 13936; bugfix on 0.1.1.5-alpha.
+

+ 2 - 1
changes/bug13942

@@ -1,5 +1,6 @@
   o Minor bugfixes (hidden services):
     - Pre-check directory permissions for new hidden-services to avoid
       at least one case of "Bug: Acting on config options left us in a
-      broken state. Dying." Fixes bug 13942.
+      broken state. Dying." Fixes bug 13942; bugfix on 0.0.6pre1.
+
 

+ 1 - 1
changes/bug14001-clang-warning

@@ -3,4 +3,4 @@
       always be non-NULL. clang recognises this and complains.
       Disable the tautologous and redundant check to silence
       this warning.
-      Fixes bug 14001.
+      Fixes bug 14001; bugfix on 0.2.1.2-alpha.

+ 2 - 2
changes/bug14002-osx-transproxy-ipfw-pf

@@ -1,4 +1,4 @@
-  o Minor bugfixes:
+  o Minor features:
     - OS X uses ipfw (FreeBSD) or pf (OpenBSD). Update the transparent
       proxy option checks to allow for both ipfw and pf on OS X.
-      Fixes bug 14002.
+      Closes ticket 14002.

+ 1 - 1
changes/bug7803

@@ -2,4 +2,4 @@
     - Tor clients no longer support connecting to hidden services running on
       Tor 0.2.2.x and earlier; the Support022HiddenServices option has been
       removed.  (There shouldn't be any hidden services running these
-      versions on the network.)
+      versions on the network.)  Closes ticket 7803.

+ 6 - 8
changes/spurious-clang-warnings

@@ -1,10 +1,8 @@
   o Minor bugfixes:
     - Silence clang warnings under --enable-expensive-hardening, including:
-        + implicit truncation of 64 bit values to 32 bit;
-        + const char assignment to self;
-        + tautological compare; and
-        + additional parentheses around equality tests. (gcc uses these to
-          silence assignment, so clang warns when they're present in an
-          equality test. But we need to use extra parentheses in macros to
-          isolate them from other code).
-      Fixes bug 13577.
+      implicit truncation of 64 bit values to 32 bit;
+      const char assignment to self;
+      tautological compare; and
+      additional parentheses around equality tests.
+      Fixes bug 13577; bugfix on 0.2.5.4-alpha.
+

+ 1 - 0
changes/ticket-11291

@@ -2,3 +2,4 @@
     - New HiddenServiceDirGroupReadable option to cause hidden service
       directories and hostname files to be created group-readable.
       Patch from "anon", David Stainton, and "meejah".
+      Closes ticket 11291.

+ 6 - 3
scripts/maint/lintChanges.py

@@ -32,11 +32,14 @@ def lintfile(fname):
 
     if isBug and not re.search(r'(\d+)', contents):
         warn("bugfix does not mention a number")
-    elif isBug and not re.search(r'Fixes bug (\d+)', contents):
+    elif isBug and not re.search(r'Fixes ([a-z ]*)bug (\d+)', contents):
         warn("bugfix does not say 'Fixes bug XXX'")
 
-    if re.search(r'[bB]ug (\d+)', contents) and not re.search(r'Bugfix on ', contents):
-        warn("bugfix does not say 'bugfix on X.Y.Z'")
+    if re.search(r'[bB]ug (\d+)', contents):
+        if not re.search(r'[Bb]ugfix on ', contents):
+            warn("bugfix does not say 'bugfix on X.Y.Z'")
+        elif not re.search('[fF]ixes ([a-z ]*)bug (\d+); bugfix on ', contents):
+            warn("bugfix incant is not semicoloned")
 
 
 if __name__=='__main__':