浏览代码

mark two more bugs. nick, can you take a look?

svn:r3920
Roger Dingledine 20 年之前
父节点
当前提交
5bdab005c9
共有 1 个文件被更改,包括 5 次插入0 次删除
  1. 5 0
      src/or/connection_edge.c

+ 5 - 0
src/or/connection_edge.c

@@ -34,6 +34,8 @@ connection_close_unattached_ap(connection_t *conn, int endreason) {
     socks5_reply_status_t socksreason =
     socks5_reply_status_t socksreason =
       connection_edge_end_reason_socks5_response(endreason);
       connection_edge_end_reason_socks5_response(endreason);
 
 
+//XXX Bug: it's not marked for close yet, so the below things won't
+// be defined yet. -RD
     if (endreason == END_STREAM_REASON_ALREADY_SOCKS_REPLIED)
     if (endreason == END_STREAM_REASON_ALREADY_SOCKS_REPLIED)
       log_fn(LOG_WARN,"Bug: stream (marked at %s:%d) sending two socks replies?",
       log_fn(LOG_WARN,"Bug: stream (marked at %s:%d) sending two socks replies?",
              conn->marked_for_close_file, conn->marked_for_close);
              conn->marked_for_close_file, conn->marked_for_close);
@@ -44,6 +46,9 @@ connection_close_unattached_ap(connection_t *conn, int endreason) {
       connection_ap_handshake_socks_resolved(conn,RESOLVED_TYPE_ERROR,0,NULL);
       connection_ap_handshake_socks_resolved(conn,RESOLVED_TYPE_ERROR,0,NULL);
   }
   }
 
 
+//XXX Bug: this means that marked-for-close-file and marked-for-close
+// will all be defined as being inside this function. that's not what
+// we had in mind. -RD
   connection_mark_for_close(conn);
   connection_mark_for_close(conn);
   conn->hold_open_until_flushed = 1;
   conn->hold_open_until_flushed = 1;
 }
 }