further cleanups

ChangeLog

@@ -1,5 +1,10 @@
-Changes in version 0.2.3.8-alpha - 2011-11-??
+Changes in version 0.2.3.8-alpha - 2011-11-21
   o Major bugfixes:
+    - Initialize Libevent with the EVENT_BASE_FLAG_NOLOCK flag enabled, so
+      that it doesn't attempt to allocate a socketpair. This could cause
+      some problems on Windows systems with overzealous firewalls. Fix for
+      bug 4457; workaround for Libevent versions 2.0.1-alpha through
+      2.0.15-stable.
     - Correctly sanity-check that we don't underflow on a memory
       allocation (and then assert) for hidden service introduction
       point decryption. Bug discovered by Dan Rosenberg. Fixes bug 4410;
@@ -26,60 +31,57 @@ Changes in version 0.2.3.8-alpha - 2011-11-??
       ticket 4442.
 
   o Minor bugfixes (on 0.2.2.x and earlier):
-    - Fix a memory leak when we check whether a hidden service
-      descriptor has any usable introduction points left. Fixes bug
-      4424. Bugfix on 0.2.2.25-alpha.
-    - Fix a memory leak in launch_direct_bridge_descriptor_fetch() that
-      occurred when a client tried to fetch a descriptor for a bridge
-      in ExcludeNodes. Fixes #4383; bugfix on 0.2.2.25-alpha.
+    - Detect failure to initialize Libevent. This fix provides better
+      detection for future instances of bug 4457.
+    - Don't warn about unused log_mutex in log.c when building with
+      --disable-threads using a recent GCC. Fixes bug 4437; bugfix on
+      0.1.0.6-rc which introduced --disable-threads.
     - Allow manual 'authenticate' commands to the controller interface
       from netcat (nc) as well as telnet. We were rejecting them because
       they didn't come with the expected whitespace at the end of the
       command. Bugfix on 0.1.1.1-alpha; fixes bug 2893.
-    - When sending a NETINFO cell, include the original address
-      received for the other side, not its canonical address. Found
-      by "troll_un"; fixes bug 4349; bugfix on 0.2.0.10-alpha.
-    - When running as a client without a geoip database, do not print a
-      misleading (and plain wrong) log message that we're collecting
-      dirreq statistics - we're not collecting statistics as clients.
-      Also don't create a useless (because empty) stats file in the stats/
-      directory. Fixes bug 4353; bugfix on 0.2.2.34 / 0.2.3.7-alpha.
     - Fix some (not actually triggerable) buffer size checks in usage of
       tor_inet_ntop. Fixes bug 4434; bugfix on Tor 0.2.0.1-alpha. Patch
       by Anders Sundman.
-    - Don't warn about unused log_mutex in log.c when building with
-      --disable-threads using a recent GCC. Fixes bug 4437; bugfix on
-      0.1.0.6-rc which introduced --disable-threads.
-    - Initialize Libevent with the EVENT_BASE_FLAG_NOLOCK flag enabled, so
-      that it doesn't attempt to allocate a socketpair. This could cause
-      some problems on windows systems with overzealous firewalls. Fix for
-      bug 4457; workaround for Libevent versions 2.0.1-alpha through
-      2.0.15-stable.
-    - Detect failure to initialize Libevent. Better detection for
-      bug 4457.
-    - Fix parsing of some corner-cases with tor_inet_pton. Fixes bug 4515;
-      bugfix on 0.2.0.1-alpha; fix by Anders Sundman.
+    - Fix parsing of some corner-cases with tor_inet_pton(). Fixes
+      bug 4515; bugfix on 0.2.0.1-alpha; fix by Anders Sundman.
+    - When sending a NETINFO cell, include the original address
+      received for the other side, not its canonical address. Found
+      by "troll_un"; fixes bug 4349; bugfix on 0.2.0.10-alpha.
     - Rename the bench_{aes,dmap} functions to test_*, so that tinytest
       can pick them up when the tests aren't disabled. Bugfix on
       0.2.2.4-alpha which introduced tinytest.
+    - Fix a memory leak when we check whether a hidden service
+      descriptor has any usable introduction points left. Fixes bug
+      4424. Bugfix on 0.2.2.25-alpha.
+    - Fix a memory leak in launch_direct_bridge_descriptor_fetch() that
+      occurred when a client tried to fetch a descriptor for a bridge
+      in ExcludeNodes. Fixes bug 4383; bugfix on 0.2.2.25-alpha.
+    - When running as a client, do not print a misleading (and plain
+      wrong) log message that we're collecting "directory request"
+      statistics: clients don't collect statistics. Also don't create a
+      useless (because empty) stats file in the stats/ directory. Fixes
+      bug 4353; bugfix on 0.2.2.34 and 0.2.3.7-alpha.
 
   o Minor bugfixes (on 0.2.3.x):
+    - Make util unit tests build correctly with MSVC. Bugfix on
+      0.2.3.3-alpha. Patch by Gisle Vanem.
     - Successfully detect AUTH_CHALLENGE cells with no recognized
       authentication type listed. Fixes bug 4367; bugfix on 0.2.3.6-alpha.
       Found by frosty_un.
-    - If a relay receives an AUTH_CHALLENGE it can't answer, it should
-      still send a NETINFO cell to allow the connection to become open.
-      Fixes bug 4368; fix on 0.2.3.6-alpha; bug found by "frosty".
-    - Log less loudly when we get an invalid certificate from a source
-      other than a directory authority: it's not unusual to see
-      invalid certs because of clock skew. Fixes bug 4370; bugfix on
+    - If a relay receives an AUTH_CHALLENGE cell it can't answer,
+      it should still send a NETINFO cell to allow the connection to
+      become open. Fixes bug 4368; fix on 0.2.3.6-alpha; bug found by
+      "frosty".
+    - Log less loudly when we get an invalid authentication certificate
+      from a source other than a directory authority: it's not unusual
+      to see invalid certs because of clock skew. Fixes bug 4370; bugfix
+      on 0.2.3.6-alpha.
+    - Tolerate servers with more clock skew in their authentication
+      certificates than previously. Fixes bug 4371; bugfix on
       0.2.3.6-alpha.
-    - Tolerate servers with more clock skew than previously. Fixes
-      bug 4371; bugfix on 0.2.3.6-alpha.
     - Fix a couple of compile warnings on Windows. Fixes bug 4469; bugfix
       on 0.2.3.4-alpha and 0.2.3.6-alpha.
-    - Make util unit tests build correctly with MSVC. Bugfix on
-      0.2.3.3-alpha. Patch by Gisle Vanem.
 
   o Minor features:
     - When Tor ignores a hidden service specified in its configuration,
@@ -91,8 +93,8 @@ Changes in version 0.2.3.8-alpha - 2011-11-??
       turn requires a working socketpair(). This is a workaround for bug
       4457, which affects Libevent versions from 2.0.1-alpha through
       2.0.15-stable.
-    - Detect when we build on a platform that doesn't define AF_UNSPEC
-      to 0. We don't work there, so refuse to compile.
+    - Detect when we try to build on a platform that doesn't define
+      AF_UNSPEC to 0. We don't work there, so refuse to compile.
     - Update to the November 1 2011 Maxmind GeoLite Country database.
 
   o Packaging changes:
@@ -113,7 +115,7 @@ Changes in version 0.2.3.8-alpha - 2011-11-??
     - The long-disabled benchmark tests are now split into their own
       ./src/test/bench binary.
     - The benchmark tests can now use more accurate timers than
-      gettimeofday when such timers are available.
+      gettimeofday() when such timers are available.
 
 
 Changes in version 0.2.3.7-alpha - 2011-10-30