Browse Source

Merge remote-tracking branch 'teor/bug24736_028' into maint-0.2.9

Nick Mathewson 6 years ago
parent
commit
6e5e4f92ab
2 changed files with 8 additions and 0 deletions
  1. 6 0
      changes/bug24736
  2. 2 0
      src/or/policies.c

+ 6 - 0
changes/bug24736

@@ -0,0 +1,6 @@
+  o Minor bugfixes (address selection):
+    - When the fascist_firewall_choose_address_ functions don't find a
+      reachable address, set the returned address to the null address and port.
+      This is a precautionary measure, because some callers do not check the
+      return value.
+      Fixes bug 24736; bugfix on 0.2.8.2-alpha.

+ 2 - 0
src/or/policies.c

@@ -854,6 +854,8 @@ fascist_firewall_choose_address_base(const tor_addr_t *ipv4_addr,
     ap->port = result->port;
     return 1;
   } else {
+    tor_addr_make_null(&ap->addr, AF_UNSPEC);
+    ap->port = 0;
     return 0;
   }
 }