Browse Source

Fix issues that shellcheck found in chutney-git-bisect.sh

rl1987 5 years ago
parent
commit
8b5ad246e8
2 changed files with 6 additions and 3 deletions
  1. 3 0
      changes/ticket28006
  2. 3 3
      scripts/test/chutney-git-bisect.sh

+ 3 - 0
changes/ticket28006

@@ -0,0 +1,3 @@
+  o Code simplification and refactoring:
+    - Fix issues that shellcheck found in chutney-git-bisect.sh.
+      Resolves ticket 28006.

+ 3 - 3
scripts/test/chutney-git-bisect.sh

@@ -20,7 +20,7 @@ if [ ! -z "$1" ]; then
 fi
 
 if [ ! -z "$2" ]; then
-    cd "$2"
+    cd "$2" || exit
 fi
 
 CHUTNEY_TEST_CMD="make test-network-all"
@@ -54,9 +54,9 @@ while [ "$i" -le "$CHUTNEY_TRIES" ]; do
         echo "test '$CHUTNEY_TEST_CMD' succeeded after $i/$CHUTNEY_TRIES attempts, good"
         exit 0
     fi
-    i=$[$i+1]
+    i=$((i+1))
 done
 
-i=$[$i-1]
+i=$((i-1))
 echo "test '$CHUTNEY_TEST_CMD' failed $i/$CHUTNEY_TRIES attempts, bad"
 exit 1