Browse Source

Downgrade a harmless bug warning to info.

Makes 19926 less annoying in 0.2.9.  In 0.3.0, we should actually
fix this.
Nick Mathewson 7 years ago
parent
commit
a40d212383
2 changed files with 6 additions and 1 deletions
  1. 3 0
      changes/bug19926_029_info
  2. 3 1
      src/or/connection_edge.c

+ 3 - 0
changes/bug19926_029_info

@@ -0,0 +1,3 @@
+  o Minor bugfixes (logging):
+    - Downgrade a harmless log message about the pending_entry_connections
+      list from "warn" to "info". Mitigates bug 19926.

+ 3 - 1
src/or/connection_edge.c

@@ -865,7 +865,9 @@ connection_ap_attach_pending(int retry)
       continue;
     }
     if (conn->state != AP_CONN_STATE_CIRCUIT_WAIT) {
-      log_warn(LD_BUG, "%p is no longer in circuit_wait. Its current state "
+      // XXXX 030 -- this is downgraded in 0.2.9, since we apparently
+      // XXXX are running into it in practice.  It's harmless.
+      log_info(LD_BUG, "%p is no longer in circuit_wait. Its current state "
                "is %s. Why is it on pending_entry_connections?",
                entry_conn,
                conn_state_to_string(conn->type, conn->state));