Browse Source

Log warning messages _before_ exiting because of earlier dcfg failure

This helps diagnostics.
Nick Mathewson 5 years ago
parent
commit
a8ca464cee
1 changed files with 5 additions and 2 deletions
  1. 5 2
      src/lib/pubsub/pubsub_build.c

+ 5 - 2
src/lib/pubsub/pubsub_build.c

@@ -281,11 +281,14 @@ pubsub_builder_finalize(pubsub_builder_t *builder,
   dispatch_t *dispatcher = NULL;
   tor_assert_nonfatal(builder->n_connectors == 0);
 
-  if (builder->n_errors)
+  if (pubsub_builder_check(builder) < 0)
     goto err;
 
-  if (pubsub_builder_check(builder) < 0)
+  if (builder->n_errors) {
+    log_warn(LD_GENERAL, "At least one error occurred previously when "
+             "configuring the dispatcher.");
     goto err;
+  }
 
   dispatcher = dispatch_new(builder->cfg);