Browse Source

resolve one more, and leave two for nick.

svn:r13644
Roger Dingledine 17 years ago
parent
commit
b28a342e35
3 changed files with 6 additions and 2 deletions
  1. 2 1
      src/common/tortls.c
  2. 2 1
      src/or/connection.c
  3. 2 0
      src/or/dns.c

+ 2 - 1
src/common/tortls.c

@@ -285,7 +285,8 @@ tor_tls_get_error(tor_tls_t *tls, int r, int extra,
       log(severity, LD_NET, "TLS error: Zero return");
       tls_log_errors(tls, severity, doing);
       /* XXXX020rc Actually, a 'zero return' error has a pretty specific
-       * meaning: the connection has been closed cleanly.  */
+       * meaning: the connection has been closed cleanly. -NM
+       * Great. Do something smart here then. :) -RD */
       return TOR_TLS_ERROR_MISC;
     default:
       tls_log_errors(tls, severity, doing);

+ 2 - 1
src/or/connection.c

@@ -1861,7 +1861,8 @@ loop_again:
      * we need to invoke the appropriate callbacks ourself. */
     connection_t *linked = conn->linked_conn;
     /* XXXX020rc Do we need to ensure that this stuff is called even if
-     * conn dies in a way that causes us to return -1 earlier? */
+     * conn dies in a way that causes us to return -1 earlier? -NM
+     * No idea. -RD */
 
     if (n_read) {
       /* Probably a no-op, but hey. */

+ 2 - 0
src/or/dns.c

@@ -592,6 +592,8 @@ dns_resolve(edge_connection_t *exitconn)
         // main.c. -NM
         // "<armadev> If that's true, there are other bugs around, where we
         //  don't check if it's marked, and will end up double-freeing."
+        // On the other hand, I don't know of any actual bugs here, so this
+        // shouldn't be holding up the rc. -RD
       }
       break;
     default: