Browse Source

Unmap microdesc cache before replacing it.

If we do a replace-then-munmap, windows will never actually rewrite
the microdesc cache.

Found by wanoskarnet; bugfix on 0.2.2.6-alpha.
Nick Mathewson 14 years ago
parent
commit
bdff7e3299
2 changed files with 9 additions and 2 deletions
  1. 6 0
      changes/md_cache_replace
  2. 3 2
      src/or/microdesc.c

+ 6 - 0
changes/md_cache_replace

@@ -0,0 +1,6 @@
+  o Minor bugfixes
+    - Avoid a bug that would keep us from replacing a microdescriptor
+      cache on Windows.  (We would try to replace the file while still
+      holding it open.  That's fine on Unix, but Windows doesn't let us
+      do that.)  Bugfix on 0.2.2.6-alpha; bug found by wanoskarnet.
+

+ 3 - 2
src/or/microdesc.c

@@ -399,10 +399,11 @@ microdesc_cache_rebuild(microdesc_cache_t *cache, int force)
     smartlist_add(wrote, md);
   }
 
-  finish_writing_to_file(open_file); /*XXX Check me.*/
-
   if (cache->cache_content)
     tor_munmap_file(cache->cache_content);
+
+  finish_writing_to_file(open_file); /*XXX Check me.*/
+
   cache->cache_content = tor_mmap_file(cache->cache_fname);
 
   if (!cache->cache_content && smartlist_len(wrote)) {