Browse Source

backport candidate:
Make it possible to read the PROTOCOLINFO response in a way that
conforms to our control-spec. Reported by Matt Edman.


svn:r11251

Roger Dingledine 18 years ago
parent
commit
c02fb8997b
3 changed files with 4 additions and 2 deletions
  1. 2 0
      ChangeLog
  2. 1 1
      doc/spec/control-spec.txt
  3. 1 1
      src/or/control.c

+ 2 - 0
ChangeLog

@@ -24,6 +24,8 @@ Changes in version 0.2.0.6-alpha - 2007-??-??
     - Stop putting the authentication cookie in a file called "0"
     - Stop putting the authentication cookie in a file called "0"
       in your working directory if you don't specify anything for the
       in your working directory if you don't specify anything for the
       new CookieAuthFile option. Reported by Matt Edman.
       new CookieAuthFile option. Reported by Matt Edman.
+    - Make it possible to read the PROTOCOLINFO response in a way that
+      conforms to our control-spec. Reported by Matt Edman.
     - Fix a minor memory leak when we fail to find enough suitable
     - Fix a minor memory leak when we fail to find enough suitable
       servers to choose a circuit. Bugfix on 0.1.2.x.
       servers to choose a circuit. Bugfix on 0.1.2.x.
     - Stop leaking part of the descriptor when we run into a particularly
     - Stop leaking part of the descriptor when we run into a particularly

+ 1 - 1
doc/spec/control-spec.txt

@@ -741,7 +741,7 @@ $Id$
     "PROTOCOLINFO" *(SP PIVERSION) CRLF
     "PROTOCOLINFO" *(SP PIVERSION) CRLF
 
 
   The server reply format is:
   The server reply format is:
-    "250+PROTOCOLINFO" SP PIVERSION CRLF *InfoLine "250 OK" CRLF
+    "250-PROTOCOLINFO" SP PIVERSION CRLF *InfoLine "250 OK" CRLF
 
 
     InfoLine = AuthLine / VersionLine / OtherLine
     InfoLine = AuthLine / VersionLine / OtherLine
 
 

+ 1 - 1
src/or/control.c

@@ -2321,7 +2321,7 @@ handle_control_protocolinfo(control_connection_t *conn, uint32_t len,
     }
     }
 
 
     connection_printf_to_buf(conn,
     connection_printf_to_buf(conn,
-                             "250+PROTOCOLINFO 1\r\n"
+                             "250-PROTOCOLINFO 1\r\n"
                              "250-AUTH METHODS=%s%s%s\r\n"
                              "250-AUTH METHODS=%s%s%s\r\n"
                              "250-VERSION Tor=%s\r\n"
                              "250-VERSION Tor=%s\r\n"
                              "250 OK\r\n",
                              "250 OK\r\n",