Browse Source

Help users who try to use v2 client auth in v3 onions.

George Kadianakis 4 years ago
parent
commit
e8e42f4af9
2 changed files with 14 additions and 0 deletions
  1. 4 0
      changes/bug28966
  2. 10 0
      src/feature/hs/hs_config.c

+ 4 - 0
changes/bug28966

@@ -0,0 +1,4 @@
+  o Minor features (onion services v3):
+    - Assist users who try to setup v2 client authorization in v3 onion
+      services by pointing them to the right documentation. Closes ticket
+      28966.

+ 10 - 0
src/feature/hs/hs_config.c

@@ -253,6 +253,16 @@ config_has_invalid_options(const config_line_t *line_,
                             "version %" PRIu32 " of service in %s",
                  opt, service->config.version,
                  service->config.directory_path);
+
+        if (!strcasecmp(line->key, "HiddenServiceAuthorizeClient")) {
+          /* Special case this v2 option so that we can offer alternatives.
+           * If more such special cases appear, it would be good to
+           * generalize the exception mechanism here. */
+          log_warn(LD_CONFIG, "For v3 onion service client authorization, "
+                   "please read the 'CLIENT AUTHORIZATION' section in the "
+                   "manual.");
+        }
+
         ret = 1;
         /* Continue the loop so we can find all possible options. */
         continue;