소스 검색

if we have enough usable guards, just pick one

we don't need to check whether we don't have enough guards right after
concluding that we do have enough.

slight efficiency fix suggested by an anonymous fellow on irc.
Roger Dingledine 14 년 전
부모
커밋
e98c9a1bf6
1개의 변경된 파일1개의 추가작업 그리고 1개의 파일을 삭제
  1. 1 1
      src/or/circuitbuild.c

+ 1 - 1
src/or/circuitbuild.c

@@ -4186,7 +4186,7 @@ choose_random_entry(cpath_build_state_t *state)
         goto choose_and_finish;
       }
       if (smartlist_len(live_entry_guards) >= options->NumEntryGuards)
-        break; /* we have enough */
+        goto choose_and_finish; /* we have enough */
   } SMARTLIST_FOREACH_END(entry);
 
   if (entry_list_is_constrained(options)) {