Browse Source

doc: Fix an incorrect comment about calling FreeLibrary() on Windows

There's an incorrect comment in compat_time.c that suggests we call
FreeLibrary() before we're done using the library's functions.
See 29642 for background.

Closes ticket 29643.
teor 6 years ago
parent
commit
f186f21a4e
1 changed files with 3 additions and 1 deletions
  1. 3 1
      src/lib/time/compat_time.c

+ 3 - 1
src/lib/time/compat_time.c

@@ -522,7 +522,9 @@ monotime_init_internal(void)
     GetTickCount64_fn = (GetTickCount64_fn_t)
     GetTickCount64_fn = (GetTickCount64_fn_t)
       GetProcAddress(h, "GetTickCount64");
       GetProcAddress(h, "GetTickCount64");
   }
   }
-  // FreeLibrary(h) ?
+  // We can't call FreeLibrary(h) here, because freeing the handle may
+  // unload the library, and cause future calls to GetTickCount64_fn()
+  // to fail. See 29642 for details.
 }
 }
 
 
 void
 void