Browse Source

Merge remote-tracking branch 'tor-github/pr/449'

Nick Mathewson 7 years ago
parent
commit
f27279f857
2 changed files with 5 additions and 2 deletions
  1. 3 0
      changes/ticket28011
  2. 2 2
      scripts/maint/run_calltool.sh

+ 3 - 0
changes/ticket28011

@@ -0,0 +1,3 @@
+  o Code simplification and refactoring:
+    - Fix shellcheck warnings in run_calltool.sh. Resolves
+      ticket 28011.

+ 2 - 2
scripts/maint/run_calltool.sh

@@ -15,10 +15,10 @@ SUBITEMS="fn_graph fn_invgraph fn_scc fn_scc_weaklinks module_graph module_invgr
 
 
 for calculation in $SUBITEMS; do
 for calculation in $SUBITEMS; do
   echo "======== $calculation"
   echo "======== $calculation"
-  python -m calltool $calculation > callgraph/$calculation
+  python -m calltool "$calculation" > callgraph/"$calculation"
 done
 done
 
 
-echo <<EOF > callgraph/README
+cat <<EOF > callgraph/README
 This directory holds output from calltool, as run on Tor.  For more
 This directory holds output from calltool, as run on Tor.  For more
 information about each of these files, see the NOTES and README files in
 information about each of these files, see the NOTES and README files in
 the calltool distribution.
 the calltool distribution.