fix a bunch of lintchanges complaints

changes/21662_21663_21664

@@ -1,4 +1,4 @@
-  o Major features:
+  o Major features (directory system):
     - Tor's compression module now includes support for the zstd and lzma2
       compression algorithms, if the libzstd and liblzma libraries are
       available when Tor is compiled.  Once these features are exposed in the

changes/bug16706

@@ -1,3 +1,3 @@
   o Minor bugfixes (hidden service):
     - Stop printing cryptic warning when a client tries to connect on an
-      invalid port of the service. Fixes #16706.; bugfix on tor-0.2.6.3-alpha.
+      invalid port of the service. Fixes bug 16706; bugfix on 0.2.6.3-alpha.

changes/bug16861

@@ -1,4 +1,4 @@
- o Major features (traffic analysis)
+  o Major features (traffic analysis resistance):
    - Relays and clients will now send a padding cell on idle OR
      connections every 1.5 to 9.5 seconds (tunable via consensus
      parameters). Directory connections and inter-relay connections
@@ -9,7 +9,7 @@
      by setting ConnectionPadding 0 in torrc. Padding may be minimized
      for mobile users with the torrc option ReducedConnectionPadding.
      Implements Proposal 251 and Section 2 of Proposal 254; closes ticket
-     #16861.
+     16861.
    - Relays will publish 24 hour totals of padding and non-padding cell
      counts to their extra-info descriptors, unless PaddingStatistics 0
      is set in torrc. These 24 hour totals are also rounded to multiples

changes/bug17592

@@ -1,9 +1,9 @@
- o Minor bugfixes (connection lifespan)
+  o Minor bugfixes (connection lifespan):
    - Allow more control over how long TLS connections are kept open: unify
      CircuitIdleTimeout and PredictedPortsRelevanceTime into a single option
      called CircuitsAvailableTimeout. Also, allow the consensus to control
      the default values for both this preference, as well as the lifespan
-     of relay-to-relay connections. Fixes bug #17592.
+     of relay-to-relay connections. Fixes bug 17592.
    - Increase the intial circuit build timeout testing frequency, to help
      ensure that ReducedConnectionPadding clients finish learning a timeout
      before their orconn would expire. The initial testing rate was set back

changes/bug17604

@@ -1,4 +1,4 @@
- o Minor bugfixes (connection usage)
+  o Minor bugfixes (connection usage):
    - Use NETINFO cells to try to determine if both relays involved in
      a connection will agree on the canonical status of that connection.
      Prefer the connections where this is the case for extend cells,
@@ -6,7 +6,7 @@
      status early. Also, additionally alter the connection selection
      logic to prefer the oldest valid connection for extend cells.
      These two changes should reduce the number of long-term connections
-     that are kept open between relays. Fixes bug #17604.
+     that are kept open between relays. Fixes bug 17604.
    - Relays will now log hourly statistics on the total number of
      connections to other relays. If the number of connections per relay
      unexpectedly large, this log message is at notice level. Otherwise

changes/bug21155

@@ -2,4 +2,4 @@
     - Warn user if multiple entries in  EntryNodes and at least one
       HiddenService are used together. Pinning EntryNodes along with an hidden
       service can be possibly harmful for instance see ticket 14917 or 21155.
-      Closes bug 21155.
+      Fixes bug 21155.

changes/bug21293

@@ -2,4 +2,4 @@
     - Downgrade a log statement from bug to protocol warning because there is
       at least one use case where it can be triggered by a buggy tor
       implementation on the Internet for instance. Fixes bug 21293; bugfix on
-      tor-0.1.1.14-alpha.
+      0.1.1.14-alpha.

changes/bug21329

@@ -1,3 +1,3 @@
   o Minor bugfixes (controller):
     - GETINFO onions/current and onions/detached no longer 551 on empty lists
-      Fixes bug 21329
+      Fixes bug 21329.

changes/bug21586

@@ -1,4 +1,4 @@
   o Minor bugfix (directory authority):
     - Prevent the shared randomness subsystem from asserting when initialized
       by a bridge authority with an incomplete configuration file. Fixes bug
-      #21856; bugfix on 0.2.9.8.
+      21586; bugfix on 0.2.9.8.

changes/bug21641

@@ -1,5 +1,5 @@
   o Minor feature (defaults, directory):
     - Onion key rotation and expiry intervals are now defined as a network
-      consensus parameter as per proposal #274. The default lifetime of an
+      consensus parameter as per proposal 274. The default lifetime of an
       onion key is bumped from 7 to 28 days. Old onion keys will expire after 7
-      days by default. Fixes bug #21641.
+      days by default. Fixes bug 21641.

changes/bug21654

@@ -1,4 +1,4 @@
-  o Code simplifications and refactoring
+  o Minor bugfixes (testing):
     - Use unbuffered I/O for utility functions around the process_handle_t
       type. This fixes unit test failures reported on OpenBSD and FreeBSD.
       Fixes bug 21654.

changes/bug21715

@@ -1,4 +1,4 @@
-  o Documentation (man page):
+  o Minor bugfixes (documentation):
     - Default of NumEntryGuards is 1 if the consensus parameter
       guard-n-primary-guards-to-use isn't set. Default of NumDirectoryGuards
       is 3 if the consensus parameter guard-n-primary-dir-guards-to-use isn't

changes/bug21788

@@ -1,3 +1,3 @@
-  o Minor bugfixes:
+  o Minor bugfixes (memory leak):
     - Fix a small memory leak at exit from the backtrace handler code.
       Fixes bug 21788; bugfix on 0.2.5.2-alpha. Patch from Daniel Pinto.

changes/bug22060

@@ -1,4 +1,4 @@
-  o Remove configuration option (confic):
+  o Removed features (configuration options, all in ticket 22060):
     - AllowInvalidNodes was deprecated in 0.2.9.2-alpha and now has been
       removed. It is not possible anymore to use Invalid nodes.
     - AllowSingleHopCircuits was deprecated in 0.2.9.2-alpha and now has been
@@ -25,3 +25,4 @@
       P256 EC group is always used.
     - {Control,DNS,Dir,Socks,Trans,NATD,OR}ListenAddress was deprecated in
       0.2.9.2-alpha and now has been removed. Use the ORPort (and others).
+

changes/fast_channel_lookup

@@ -1,2 +1,2 @@
-  o Minor features:
+  o Minor features (performance, controller):
     - Add an O(1) implementation of channel_find_by_global_id().

changes/test21470

@@ -1,4 +1,4 @@
-  o Minor enhancements (unit tests):
+  o Minor features (unit tests):
     - Improve version parsing tests: add tests for typical version components,
       add tests for invalid versions, including numeric range and non-numeric
       prefixes.

changes/ticket21953

@@ -1,4 +1,4 @@
-  o Minor features:
+  o Minor features (security, windows):
     - Enable a couple of pieces of Windows hardening: one
       (HeapEnableTerminationOnCorruption) that has been on-by-default since
       Windows 8, and unavailable before Windows 7, and one

changes/ticket4998

@@ -1,4 +1,4 @@
-  o Minor features:
+  o Minor features (relay, configuration):
     - The MyFamily line may now be repeated as many times as desired, for
       relays that want to configure large families. Closes ticket 4998;
       patch by Daniel Pinto.