The main loop of the server is currently using ? on incoming connections. While this is fine for bind, since there's nothing reasonable to do if that fails, it's not okay for handling accept or parse_identifier, since that means a client can crash the server by disconnecting any time before their identifier gets sent over the wire.
The main loop of the server is currently using `?` on incoming connections. While this is fine for `bind`, since there's nothing reasonable to do if that fails, it's not okay for handling `accept` or `parse_identifier`, since that means a client can crash the server by disconnecting any time before their identifier gets sent over the wire.
The main loop of the server is currently using
?on incoming connections. While this is fine forbind, since there's nothing reasonable to do if that fails, it's not okay for handlingacceptorparse_identifier, since that means a client can crash the server by disconnecting any time before their identifier gets sent over the wire.Fixed via
22de85567f