Browse Source

Fix null test and write test issues about the stat parameter

This issue may cause SegFault if pass null to state,
and miss the validation by test_user_memory(...) if not null.
Gary 5 years ago
parent
commit
5d799d27f9
1 changed files with 2 additions and 2 deletions
  1. 2 2
      LibOS/shim/src/sys/shim_stat.c

+ 2 - 2
LibOS/shim/src/sys/shim_stat.c

@@ -39,7 +39,7 @@ int shim_do_stat (const char * file, struct stat * stat)
     if (!file || test_user_string(file))
         return -EFAULT;
 
-    if (!stat && test_user_memory(stat, sizeof(*stat), true))
+    if (!stat || test_user_memory(stat, sizeof(*stat), true))
         return -EFAULT;
 
     int ret;
@@ -67,7 +67,7 @@ int shim_do_lstat (const char * file, struct stat * stat)
     if (!file || test_user_string(file))
         return -EFAULT;
 
-    if (!stat && test_user_memory(stat, sizeof(*stat), true))
+    if (!stat || test_user_memory(stat, sizeof(*stat), true))
         return -EFAULT;
 
     int ret;