Browse Source

Avoid assertion failure on unexepcted address family in DNS reply.

Fixes bug 9337; bugfix on 0.2.4.7-alpha.
Nick Mathewson 10 years ago
parent
commit
11f1b7d9df
2 changed files with 8 additions and 4 deletions
  1. 4 0
      changes/bug9337
  2. 4 4
      src/or/dns.c

+ 4 - 0
changes/bug9337

@@ -0,0 +1,4 @@
+  o Major bugfixes (DNS):
+    - Avoid an assertion failure when processing DNS replies without the
+      answer types we expected. Fixes bug 9337; bugfix on 0.2.4.7-alpha.
+

+ 4 - 4
src/or/dns.c

@@ -437,8 +437,8 @@ cached_resolve_add_answer(cached_resolve_t *resolve,
     if (resolve->res_status_ipv4 != RES_STATUS_INFLIGHT)
       return;
 
-    if (dns_result == DNS_ERR_NONE && answer_addr) {
-      tor_assert(tor_addr_family(answer_addr) == AF_INET);
+    if (dns_result == DNS_ERR_NONE && answer_addr &&
+        tor_addr_family(answer_addr) == AF_INET) {
       resolve->result_ipv4.addr_ipv4 = tor_addr_to_ipv4h(answer_addr);
       resolve->res_status_ipv4 = RES_STATUS_DONE_OK;
     } else {
@@ -450,8 +450,8 @@ cached_resolve_add_answer(cached_resolve_t *resolve,
     if (resolve->res_status_ipv6 != RES_STATUS_INFLIGHT)
       return;
 
-    if (dns_result == DNS_ERR_NONE && answer_addr) {
-      tor_assert(tor_addr_family(answer_addr) == AF_INET6);
+    if (dns_result == DNS_ERR_NONE && answer_addr &&
+        tor_addr_family(answer_addr) == AF_INET6) {
       memcpy(&resolve->result_ipv6.addr_ipv6,
              tor_addr_to_in6(answer_addr),
              sizeof(struct in6_addr));