Browse Source

add a note from wanoskarnet

he disagrees about what the code that we decided not to use would do
Roger Dingledine 13 years ago
parent
commit
1416dd47a9
1 changed files with 5 additions and 0 deletions
  1. 5 0
      src/common/tortls.c

+ 5 - 0
src/common/tortls.c

@@ -781,6 +781,11 @@ tor_tls_context_new(crypto_pk_env_t *identity, unsigned int key_lifetime,
    * with clients that are configured to use SSLv23_method(), so we should
    * with clients that are configured to use SSLv23_method(), so we should
    * probably never use it.
    * probably never use it.
    */
    */
+  /* XXX wanoskarnet says this comment is bunk -- that even if we turn
+   * this line on, clients configured to use SSLv23 would still able to
+   * talk to us. But he also says it's ok to leave it out. I suggest we
+   * delete this whole clause (the one that's #if 0'ed out). I'll leave
+   * it in place until Nick expresses an opinion. -RD */
   if (!(result->ctx = SSL_CTX_new(TLSv1_method())))
   if (!(result->ctx = SSL_CTX_new(TLSv1_method())))
     goto error;
     goto error;
 #endif
 #endif