Browse Source

answer question about rep_hist_note_connect_failed

svn:r2464
Nick Mathewson 21 years ago
parent
commit
149f57bdef
1 changed files with 4 additions and 0 deletions
  1. 4 0
      src/or/connection.c

+ 4 - 0
src/or/connection.c

@@ -195,6 +195,10 @@ void connection_about_to_close_connection(connection_t *conn)
         /* XXX Nick: this still isn't right, because it might be
          * dying even though we didn't initiate the connect. Can
          * you look at this more? -RD XXXX008 -NM*/
+        /* XXX We only set conn->nickname when we initiate the connection, or
+         * when the handshake is complete; so conn->nickname is a good test
+         * for "we initiated the connection", right? -NM */
+         */
         if(conn->nickname)
           rep_hist_note_connect_failed(conn->identity_digest, time(NULL));
       } else if (0) { // XXX reason == CLOSE_REASON_UNUSED_OR_CONN) {