Pārlūkot izejas kodu

Remove a dead variable in the heartbeat code

Sebastian Hahn 13 gadi atpakaļ
vecāks
revīzija
3033f8459b
2 mainītis faili ar 3 papildinājumiem un 2 dzēšanām
  1. 2 0
      changes/coverity_master
  2. 1 2
      src/or/status.c

+ 2 - 0
changes/coverity_master

@@ -1,4 +1,6 @@
   o Minor bugfixes:
     - Prevent using negative indices during unit test runs when read_all()
       fails. Spotted by coverity. Bugfix on 0.2.3.1.
+  o Code simplifications and refactoring:
+    - Remove a dead variable in the heartbeat log code. Spotted by coverity.
 

+ 1 - 2
src/or/status.c

@@ -84,7 +84,6 @@ log_heartbeat(time_t now)
   char *bw_rcvd = NULL;
   char *uptime = NULL;
   const routerinfo_t *me;
-  const node_t *myself;
 
   or_options_t *options = get_options();
   (void)now;
@@ -94,7 +93,7 @@ log_heartbeat(time_t now)
     if (!(me = router_get_my_routerinfo()))
       return -1; /* Something stinks, we won't even attempt this. */
     else
-      if (!(myself = node_get_by_id(me->cache_info.identity_digest)))
+      if (!node_get_by_id(me->cache_info.identity_digest))
         log_fn(LOG_NOTICE, LD_HEARTBEAT, "Heartbeat: It seems like we are not "
                "in the cached consensus.");
   }