Sfoglia il codice sorgente

Fix memory leak in safe-cookie authentication code

Coverity spotted this. Bug 7816. Fix on 0.2.3.13-alpha.
Nick Mathewson 11 anni fa
parent
commit
4b571d3ab3
2 ha cambiato i file con 5 aggiunte e 0 eliminazioni
  1. 3 0
      changes/bug7816_023
  2. 2 0
      src/or/control.c

+ 3 - 0
changes/bug7816_023

@@ -0,0 +1,3 @@
+  o Minor bugfixes (memory leak, controller):
+    - Fix a memory leak during safe-cookie controller authentication.
+      Spotted by Coverity. Fixes part of bug 7816; bugfix on 0.2.3.13-alpha.

+ 2 - 0
src/or/control.c

@@ -3099,6 +3099,8 @@ handle_control_authchallenge(control_connection_t *conn, uint32_t len,
                            "SERVERNONCE=%s\r\n",
                            server_hash_encoded,
                            server_nonce_encoded);
+
+  tor_free(client_nonce);
   return 0;
 }