Browse Source

Remove pre-unlink check tor_remove_file; check errno instead.

This removes a time-of-check/time-of-use issue, though in this case
it would probably be harmless.
Nick Mathewson 6 years ago
parent
commit
4b7b305bf0
1 changed files with 2 additions and 4 deletions
  1. 2 4
      src/or/main.c

+ 2 - 4
src/or/main.c

@@ -3401,11 +3401,9 @@ tor_free_all(int postfork)
 void
 tor_remove_file(const char *filename)
 {
-  if (file_status(filename) == FN_FILE) {
-    if (tor_unlink(filename) != 0) {
-      log_warn(LD_FS, "Couldn't unlink %s: %s",
+  if (tor_unlink(filename) != 0 && errno != ENOENT) {
+    log_warn(LD_FS, "Couldn't unlink %s: %s",
                filename, strerror(errno));
-    }
   }
 }