Browse Source

Merge remote-tracking branch 'sebastian/coverity'

Nick Mathewson 13 years ago
parent
commit
4f47db3280
2 changed files with 4 additions and 1 deletions
  1. 3 0
      changes/bug4637
  2. 1 1
      src/or/directory.c

+ 3 - 0
changes/bug4637

@@ -0,0 +1,3 @@
+  o Code simplifications and refactoring:
+    - Remove some dead code spotted by coverity. Fixes cid 432.
+      Bugfix on 0.2.3.1-alpha, closes bug 4637.

+ 1 - 1
src/or/directory.c

@@ -410,7 +410,7 @@ directory_get_from_dirserver(uint8_t dir_purpose, uint8_t router_purpose,
     } else {
       /* Otherwise it might be a consensus we don't parse, but which we
        * do cache.  Look at the cached copy, perhaps. */
-      cached_dir_t *cd = dirserv_get_consensus(resource ? resource : "ns");
+      cached_dir_t *cd = dirserv_get_consensus(resource);
       if (cd)
         if_modified_since = cd->published + 180;
     }