Prechádzať zdrojové kódy

Add a comment about CID 1311630 and why we won't worry about it.

Nick Mathewson 8 rokov pred
rodič
commit
53c99cce5e
1 zmenil súbory, kde vykonal 4 pridanie a 0 odobranie
  1. 4 0
      src/ext/ed25519/donna/modm-donna-64bit.h

+ 4 - 0
src/ext/ed25519/donna/modm-donna-64bit.h

@@ -261,6 +261,10 @@ contract256_slidingwindow_modm(signed char r[256], const bignum256modm s, int wi
 			continue;
 
 		for (b = 1; (b < (soplen - j)) && (b <= 6); b++) {
+			/* XXX Tor: coverity scan says that r[j+b] can
+			 * overflow, but that's not possible: b < (soplen-j)
+			 * guarantees that b + j < soplen, so b+j < 256,
+			 * so the index doesn't overflow. */
 			if ((r[j] + (r[j + b] << b)) <= m) {
 				r[j] += r[j + b] << b;
 				r[j + b] = 0;