Переглянути джерело

Fix memory leak in connection_ap_handshake_rewrite_and_attach()

Spotted by asn.  #14259.  Bugfix on 368eb6a97 in 0.2.0.1-alpha.
Nick Mathewson 9 роки тому
батько
коміт
54e4aaf52c
2 змінених файлів з 7 додано та 0 видалено
  1. 6 0
      changes/bug14259
  2. 1 0
      src/or/connection_edge.c

+ 6 - 0
changes/bug14259

@@ -0,0 +1,6 @@
+  o Minor bugfixes (client):
+    - Avoid a small memory leak when we find a cached answer for a reverse
+      DNS lookup in a client-side DNS cache. (Remember, client-side DNS
+      caching is off by default, and is not recommended.) Fixes bug 14259;
+      bugfix on 0.2.0.1-alpha.
+

+ 1 - 0
src/or/connection_edge.c

@@ -1001,6 +1001,7 @@ connection_ap_handshake_rewrite(entry_connection_t *conn,
                                              strlen(result), (uint8_t*)result,
                                              -1,
                                              out->map_expires);
+      tor_free(result);
       out->end_reason = END_STREAM_REASON_DONE |
                         END_STREAM_REASON_FLAG_ALREADY_SOCKS_REPLIED;
       out->should_close = 1;