Browse Source

scan-build: close stdio FILEs on error in tor-gencert

This is harmless, since tor-gencert exits right afterwards, but it's
best to clean up after ourselves.
Nick Mathewson 10 years ago
parent
commit
5670e38efb
1 changed files with 2 additions and 0 deletions
  1. 2 0
      src/tools/tor-gencert.c

+ 2 - 0
src/tools/tor-gencert.c

@@ -302,6 +302,7 @@ load_identity_key(void)
     if (!identity_key) {
       log_err(LD_GENERAL, "Couldn't read identity key from %s",
               identity_key_file);
+      fclose(f);
       return 1;
     }
     fclose(f);
@@ -322,6 +323,7 @@ load_signing_key(void)
   }
   if (!(signing_key = PEM_read_PrivateKey(f, NULL, NULL, NULL))) {
     log_err(LD_GENERAL, "Couldn't read siging key from %s", signing_key_file);
+    fclose(f);
     return 1;
   }
   fclose(f);