Browse Source

Fix a double-free in failing case of handle_control_authenticate.

Bugfix on ed8f020e205267e6270494634346ab68d830e1d8; bug not in any
released version of Tor.  Found by Coverity; this is CID 1239290.
Nick Mathewson 9 years ago
parent
commit
58e813d0fc
1 changed files with 1 additions and 0 deletions
  1. 1 0
      src/or/control.c

+ 1 - 0
src/or/control.c

@@ -1177,6 +1177,7 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
       });
       SMARTLIST_FOREACH(sl, char *, cp, tor_free(cp));
       smartlist_free(sl);
+      sl = NULL;
 
       if (used_quoted_string)
         errstr = "Password did not match HashedControlPassword value from "