Browse Source

Avoid a scan_build warning in dirvote_get_intermediate_param_value

Fixes bug 21495.
Nick Mathewson 6 years ago
parent
commit
67b6ba6f2f
1 changed files with 4 additions and 4 deletions
  1. 4 4
      src/or/dirvote.c

+ 4 - 4
src/or/dirvote.c

@@ -737,12 +737,12 @@ dirvote_get_intermediate_param_value(const smartlist_t *param_list,
     }
   } SMARTLIST_FOREACH_END(k_v_pair);
 
-  if (n_found == 1)
+  if (n_found == 1) {
     return value;
-  else if (BUG(n_found > 1))
-    return default_val;
-  else
+  } else {
+    tor_assert_nonfatal(n_found == 0);
     return default_val;
+  }
 }
 
 /** Minimum number of directory authorities voting for a parameter to