Browse Source

add changes file and update check-typos in makefile

Deepesh Pathak 6 years ago
parent
commit
72bfcb37f1
5 changed files with 9 additions and 6 deletions
  1. 1 1
      ChangeLog
  2. 3 3
      Makefile.am
  3. 3 0
      changes/ticket25024
  4. 1 1
      src/common/crypto_rsa.h
  5. 1 1
      src/or/protover.c

+ 1 - 1
ChangeLog

@@ -875,7 +875,7 @@ Changes in version 0.3.3.2-alpha - 2018-02-10
       would call the Rust implementation of
       protover_get_supported_protocols(). This was due to the C version
       returning a static string, whereas the Rust version newly allocated
-      a CString to pass accross the FFI boundary. Consequently, the C
+      a CString to pass across the FFI boundary. Consequently, the C
       code was not expecting to need to free() what it was given. Fixes
       bug 25127; bugfix on 0.3.2.1-alpha.
 

+ 3 - 3
Makefile.am

@@ -97,7 +97,7 @@ doxygen:
 test: all
 	$(top_builddir)/src/test/test
 
-check-local: check-spaces check-changes check-typos
+check-local: check-spaces check-changes
 
 need-chutney-path:
 	@if test ! -d "$$CHUTNEY_PATH"; then \
@@ -221,8 +221,8 @@ check-logs:
 check-typos:
 	@if test -x "`which misspell 2>&1;true`"; then \
 		echo "Checking for Typos ..."; \
-		(`which misspell` \
-			$(top_srcdir)/src/**/*.[ch] \
+		(misspell \
+			$(top_srcdir)/src/[^e]*/*.[ch] \
 			$(top_srcdir)/doc \
 			$(top_srcdir)/contrib \
 			$(top_srcdir)/scripts \

+ 3 - 0
changes/ticket25024

@@ -0,0 +1,3 @@
+  o Minor features (code quality):
+    - Add spell checking using misspell in Makefile.
+      Closes ticket 25024.

+ 1 - 1
src/common/crypto_rsa.h

@@ -35,7 +35,7 @@
 /** A public key, or a public/private key-pair. */
 typedef struct crypto_pk_t crypto_pk_t;
 
-/* RSA enviroment setup */
+/* RSA environment setup */
 MOCK_DECL(crypto_pk_t *,crypto_pk_new,(void));
 void crypto_pk_free_(crypto_pk_t *env);
 #define crypto_pk_free(pk) FREE_AND_NULL(crypto_pk_t, crypto_pk_free_, (pk))

+ 1 - 1
src/or/protover.c

@@ -715,7 +715,7 @@ protover_all_supported(const char *s, char **missing_out)
             versions->high = i;
           }
           /* If the last one to be unsupported is one less than the current
-           * one, we're in a continous range, so set the high field. */
+           * one, we're in a continuous range, so set the high field. */
           if ((versions->high && versions->high == i - 1) ||
               /* Similarly, if the last high wasn't set and we're currently
                * one higher than the low, add current index as the highest