Browse Source

Fix another coverity-spotted memleak

Sebastian Hahn 15 years ago
parent
commit
7681e355ed
2 changed files with 7 additions and 0 deletions
  1. 5 0
      ChangeLog
  2. 2 0
      src/or/control.c

+ 5 - 0
ChangeLog

@@ -1,3 +1,8 @@
+Changes in version 0.2.2.10-alpha - 2010-??-??
+  o Minor bugfixes:
+    - Fix a memleak in the EXTENDCIRCUIT logic. Spotted by coverity.
+      Bugfix on 0.2.2.9-alpha.
+
 Changes in version 0.2.2.9-alpha - 2010-02-22
   o Directory authority changes:
     - Change IP address for dannenberg (v3 directory authority), and

+ 2 - 0
src/or/control.c

@@ -2121,6 +2121,8 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len,
   if (!zero_circ && !(circ = get_circ(smartlist_get(args,0)))) {
     connection_printf_to_buf(conn, "552 Unknown circuit \"%s\"\r\n",
                              (char*)smartlist_get(args, 0));
+    SMARTLIST_FOREACH(args, char *, cp, tor_free(cp));
+    smartlist_free(args);
     goto done;
   }