Prechádzať zdrojové kódy

Fix off-by-one error when allocating memory in test_util_split_lines()

Triggered "failed OVER picket-fence magic-number check (err 27)" when
memory debugging using dmalloc is enabled (at 'low' or higher).
Steven Murdoch 12 rokov pred
rodič
commit
76fde28475
1 zmenil súbory, kde vykonal 2 pridanie a 1 odobranie
  1. 2 1
      src/test/test_util.c

+ 2 - 1
src/test/test_util.c

@@ -1637,7 +1637,8 @@ test_util_split_lines(void *ptr)
 
   for (i=0; tests[i].orig_line; i++) {
     sl = smartlist_create();
-    orig_line = tor_malloc(tests[i].orig_length);
+    /* Allocate space for string and trailing NULL */
+    orig_line = tor_malloc(tests[i].orig_length + 1);
     memcpy(orig_line, tests[i].orig_line, tests[i].orig_length + 1);
     tor_split_lines(sl, orig_line, tests[i].orig_length);