Browse Source

Tweaks to strings in 24500

Nick Mathewson 6 years ago
parent
commit
779e4b9dcf
2 changed files with 6 additions and 6 deletions
  1. 2 2
      changes/ticket24500
  2. 4 4
      src/common/crypto.c

+ 2 - 2
changes/ticket24500

@@ -1,3 +1,3 @@
-  o Code simplification and refactoring: 
-    - Making more useful log messages for errno errors on getrandom() call.
+  o Minor features (logging):
+    - Provide better warnings when the getrandom() syscall fails.
       Closes ticket 24500.

+ 4 - 4
src/common/crypto.c

@@ -2877,12 +2877,12 @@ crypto_strongest_rand_syscall(uint8_t *out, size_t out_len)
 
       /* Useful log message for errno. */
       if (errno == ENOSYS) {
-        log_warn(LD_CRYPTO, "This warning is caused by ENOSYS error."
+        log_warn(LD_CRYPTO, "Can't get entropy from getrandom(). "
                  " You are running a version of Tor built to support"
-                 " getrandom(), but the kernel is too old and doesn't"
-                 " implement this function.");
+                 " getrandom(), but the kernel doesn't implement this"
+                 " implement this function--probably because it is too old?");
       } else {
-        log_warn(LD_CRYPTO, "Can't get entropy from getrandom(). %s error.",
+        log_warn(LD_CRYPTO, "Can't get entropy from getrandom(): %s.",
                  strerror(errno));
       }