Browse Source

Fix the memory leak in `warn_if_option_path_is_relative()`.

Fixes coverity defect CID 1293337, not in any released version of tor.
Yawning Angel 9 years ago
parent
commit
79544a6fc5
1 changed files with 5 additions and 3 deletions
  1. 5 3
      src/or/config.c

+ 5 - 3
src/or/config.c

@@ -2558,10 +2558,12 @@ static void
 warn_if_option_path_is_relative(const char *option,
                                 char *filepath)
 {
-  if (filepath &&path_is_relative(filepath))
+  if (filepath && path_is_relative(filepath)) {
+    char *abs_path = make_path_absolute(filepath);
     COMPLAIN("Path for %s (%s) is relative and will resolve to %s."
-             " Is this what you wanted?",option,filepath,
-             make_path_absolute(filepath));
+             " Is this what you wanted?", option, filepath, abs_path);
+    tor_free(abs_path);
+  }
 }
 
 /** Scan <b>options</b> for occurances of relative file/directory