Browse Source

Remove a redundant check in ..transition_affects_guards()

scan-build found that we we checking UseEntryGuards twice.

Fixes bug 21492.
Nick Mathewson 7 years ago
parent
commit
823fb68a14
2 changed files with 5 additions and 1 deletions
  1. 5 0
      changes/bug21492
  2. 0 1
      src/or/config.c

+ 5 - 0
changes/bug21492

@@ -0,0 +1,5 @@
+  o Minor bugfixes (correctness):
+    - Remove a redundant check for the UseEntryGuards option from the
+      options_transition_affects_guards() function. Fixes bug 21492;
+      bugfix on 0.3.0.1-alpha.
+

+ 0 - 1
src/or/config.c

@@ -1587,7 +1587,6 @@ options_transition_affects_guards(const or_options_t *old,
   return
     (old->UseEntryGuards != new->UseEntryGuards ||
      old->UseBridges != new->UseBridges ||
-     old->UseEntryGuards != new->UseEntryGuards ||
      old->ClientUseIPv4 != new->ClientUseIPv4 ||
      old->ClientUseIPv6 != new->ClientUseIPv6 ||
      old->FascistFirewall != new->FascistFirewall ||