Browse Source

Merge branch 'maint-0.2.9' into maint-0.3.0

Nick Mathewson 6 years ago
parent
commit
9ae4ffc076
2 changed files with 8 additions and 0 deletions
  1. 3 0
      changes/bug23874
  2. 5 0
      src/or/nodelist.c

+ 3 - 0
changes/bug23874

@@ -0,0 +1,3 @@
+  o Minor bugfixes (memory safety):
+    - Clear the address when node_get_prim_orport() returns early.
+      Fixes bug 23874; bugfix on 0.2.8.2-alpha.

+ 5 - 0
src/or/nodelist.c

@@ -1127,6 +1127,11 @@ node_get_prim_orport(const node_t *node, tor_addr_port_t *ap_out)
   node_assert_ok(node);
   tor_assert(ap_out);
 
+  /* Clear the address, as a safety precaution if calling functions ignore the
+   * return value */
+  tor_addr_make_null(&ap_out->addr, AF_INET);
+  ap_out->port = 0;
+
   /* Check ri first, because rewrite_node_address_for_bridge() updates
    * node->ri with the configured bridge address. */