Browse Source

Fix a buffer overrun in connection tests.

This is CID 1343601.
Nick Mathewson 8 years ago
parent
commit
9b1c491ec6
1 changed files with 2 additions and 1 deletions
  1. 2 1
      src/test/test_connection.c

+ 2 - 1
src/test/test_connection.c

@@ -231,9 +231,10 @@ test_conn_get_rend_setup(const struct testcase_t *tc)
 
 
   /* TODO: use directory_initiate_command_rend() to do this - maybe? */
   /* TODO: use directory_initiate_command_rend() to do this - maybe? */
   conn->rend_data = tor_malloc_zero(sizeof(rend_data_t));
   conn->rend_data = tor_malloc_zero(sizeof(rend_data_t));
+  tor_assert(strlen(TEST_CONN_REND_ADDR) == REND_SERVICE_ID_LEN_BASE32);
   memcpy(conn->rend_data->onion_address,
   memcpy(conn->rend_data->onion_address,
          TEST_CONN_REND_ADDR,
          TEST_CONN_REND_ADDR,
-         REND_SERVICE_ADDRESS_LEN+1);
+         REND_SERVICE_ID_LEN_BASE32+1);
   conn->rend_data->hsdirs_fp = smartlist_new();
   conn->rend_data->hsdirs_fp = smartlist_new();
   conn->base_.purpose = TEST_CONN_REND_PURPOSE;
   conn->base_.purpose = TEST_CONN_REND_PURPOSE;