Browse Source

fix yet another time comparison bug. we were abandoning helpers
as soon as they became unavailable. (is this true?)


svn:r5565

Roger Dingledine 20 years ago
parent
commit
9c01fa3d59
1 changed files with 4 additions and 2 deletions
  1. 4 2
      src/or/circuitbuild.c

+ 4 - 2
src/or/circuitbuild.c

@@ -1751,10 +1751,12 @@ remove_dead_helpers(void)
     helper_node_t *helper = smartlist_get(helper_nodes, i);
     const char *why = NULL;
     time_t since = 0;
-    if (helper->unlisted_since + HELPER_ALLOW_UNLISTED > now) {
+    if (helper->unlisted_since &&
+        helper->unlisted_since + HELPER_ALLOW_UNLISTED < now) {
       why = "unlisted";
       since = helper->unlisted_since;
-    } else if (helper->down_since + HELPER_ALLOW_DOWNTIME > now) {
+    } else if (helper->down_since &&
+               helper->down_since + HELPER_ALLOW_DOWNTIME < now) {
       why = "down";
       since = helper->down_since;
     }