Browse Source

If out-of-disk when saving a consensus cache entry, don't BUG.

Just warn instead.

Fixes bug 24859.
Nick Mathewson 6 years ago
parent
commit
9c2bc441f8
2 changed files with 8 additions and 1 deletions
  1. 4 0
      changes/bug24859
  2. 4 1
      src/or/consdiffmgr.c

+ 4 - 0
changes/bug24859

@@ -0,0 +1,4 @@
+  o Minor bugfixes (logging):
+    - Don't treat inability to store a cached consensus object as a
+      bug: it can happen normally when we are out of disk space.
+      Fixes bug 24859; bugfix on 0.3.1.1-alpha.

+ 4 - 1
src/or/consdiffmgr.c

@@ -1310,8 +1310,11 @@ store_multiple(consensus_cache_entry_handle_t **handles_out,
                             labels,
                             body_out,
                             bodylen_out);
-      if (BUG(ent == NULL))
+      if (ent == NULL) {
+        log_warn(LD_FS, "Unable to store object %s compressed with %s.",
+                 description, methodname);
         continue;
+      }
 
       status = CDM_DIFF_PRESENT;
       handles_out[i] = consensus_cache_entry_handle_new(ent);