Browse Source

Merge branch 'maint-0.3.2' into maint-0.3.3

Nick Mathewson 5 years ago
parent
commit
a546e07600
2 changed files with 7 additions and 3 deletions
  1. 4 0
      changes/bug27335
  2. 3 3
      src/or/hs_service.c

+ 4 - 0
changes/bug27335

@@ -0,0 +1,4 @@
+  o Minor bugfixes (hidden service v3):
+    - In case the hidden service directory can't be created or has wrong
+      permissions, do not BUG() on it which lead to a non fatal stacktrace.
+      Fixes bug 27335; bugfix on 0.3.2.1.

+ 3 - 3
src/or/hs_service.c

@@ -983,9 +983,9 @@ load_service_keys(hs_service_t *service)
    * files to that directory so make sure it exists and has the right
    * permissions. We do this here because at this stage we know that Tor is
    * actually running and the service we have has been validated. */
-  if (BUG(hs_check_service_private_dir(get_options()->User,
-                                       config->directory_path,
-                                       config->dir_group_readable, 1) < 0)) {
+  if (hs_check_service_private_dir(get_options()->User,
+                                   config->directory_path,
+                                   config->dir_group_readable, 1) < 0) {
     goto end;
   }