瀏覽代碼

nodelist: use strcmpstart() instead of strncmp()

in rend_parse_v2_service_descriptor.
Fix on c58675ca728f12b42f65e5b8964ae695c2e0ec2d
cypherpunks 5 年之前
父節點
當前提交
ab91302fd0
共有 2 個文件被更改,包括 4 次插入2 次删除
  1. 3 0
      changes/ticket27630
  2. 1 2
      src/feature/nodelist/routerparse.c

+ 3 - 0
changes/ticket27630

@@ -0,0 +1,3 @@
+  o Code simplification and refactoring:
+    - Use the simpler strcmpstart() helper in rend_parse_v2_service_descriptor
+      instead of strncmp(). Closes ticket 27630.

+ 1 - 2
src/feature/nodelist/routerparse.c

@@ -5167,8 +5167,7 @@ rend_parse_v2_service_descriptor(rend_service_descriptor_t **parsed_out,
 
   tor_assert(desc);
   /* Check if desc starts correctly. */
-  if (strncmp(desc, "rendezvous-service-descriptor ",
-              strlen("rendezvous-service-descriptor "))) {
+  if (strcmpstart(desc, "rendezvous-service-descriptor ")) {
     log_info(LD_REND, "Descriptor does not start correctly.");
     goto err;
   }