Increment n_download_failures up to IMPOSSIBLE_TO_DOWNLOAD-1, not up to IMPOSSIBLE_TO_DOWNLOAD.

svn:r17835

ChangeLog

@@ -26,6 +26,9 @@ Changes in version 0.2.1.10-alpha - 2009-01-??
     - Authorities now list vote for the Stable flag for any router whose
       weighted MTBF is at least 5 days, regardless of the mean MTBF.
     - Stop logging nameserver addresses in reverse order.
+    - If we are retrying something slowly over and over, do not
+      automatically give up after the 254th failure.  Bugfix on
+      0.2.1.9-alpha.
 
   o Code simplifications and refactoring:
     - Change our header file guard macros to be less likely to conflict

src/or/directory.c

@@ -3341,7 +3341,7 @@ download_status_increment_failure(download_status_t *dls, int status_code,
   int increment;
   tor_assert(dls);
   if (status_code != 503 || server) {
-    if (dls->n_download_failures < IMPOSSIBLE_TO_DOWNLOAD)
+    if (dls->n_download_failures < IMPOSSIBLE_TO_DOWNLOAD-1)
       ++dls->n_download_failures;
   }