Explorar el Código

Improve the message we log on unexpected dirauth status code

It's still not great, but should be less confusing what's wrong
here.

Closes ticket 1121.
Nick Mathewson hace 7 años
padre
commit
b80a35e683
Se han modificado 2 ficheros con 11 adiciones y 6 borrados
  1. 4 0
      changes/bug1121
  2. 7 6
      src/or/directory.c

+ 4 - 0
changes/bug1121

@@ -0,0 +1,4 @@
+  o Minor bugfixes (logging):
+    - Provide a better log message when a directory authority responds
+      to an upload with an unexpected status code. Fixes bug 11121;
+      bugfix on 0.1.0.1-rc.

+ 7 - 6
src/or/directory.c

@@ -2895,8 +2895,9 @@ handle_response_upload_dir(dir_connection_t *conn,
     break;
   default:
     log_warn(LD_GENERAL,
-             "http status %d (%s) reason unexpected while uploading "
-             "descriptor to server '%s:%d').",
+             "HTTP status %d (%s) was unexpected while uploading "
+             "descriptor to server '%s:%d'. Possibly the server is "
+             "misconfigured?",
              status_code, escaped(reason), conn->base_.address,
              conn->base_.port);
     break;
@@ -2932,8 +2933,8 @@ handle_response_upload_vote(dir_connection_t *conn,
     break;
   default:
     log_warn(LD_GENERAL,
-             "http status %d (%s) reason unexpected while uploading "
-             "vote to server '%s:%d').",
+             "HTTP status %d (%s) was unexpected while uploading "
+             "vote to server '%s:%d'.",
              status_code, escaped(reason), conn->base_.address,
              conn->base_.port);
     break;
@@ -2968,8 +2969,8 @@ handle_response_upload_signatures(dir_connection_t *conn,
     break;
   default:
     log_warn(LD_GENERAL,
-             "http status %d (%s) reason unexpected while uploading "
-             "signatures to server '%s:%d').",
+             "HTTP status %d (%s) was unexpected while uploading "
+             "signatures to server '%s:%d'.",
              status_code, escaped(reason), conn->base_.address,
              conn->base_.port);
     break;