Browse Source

Use memset() on intro1_data in hs_circ_send_introduce1()

Neel Chauhan 6 years ago
parent
commit
b8addf9746
1 changed files with 5 additions and 0 deletions
  1. 5 0
      src/or/hs_circuit.c

+ 5 - 0
src/or/hs_circuit.c

@@ -1101,6 +1101,11 @@ hs_circ_send_introduce1(origin_circuit_t *intro_circ,
   tor_assert(ip);
   tor_assert(subcredential);
 
+  /* It is undefined behavior in hs_cell_introduce1_data_clear() if intro1_data
+   * has been declared on the stack but not initialized. Here, we set it to 0.
+   */
+  memset(&intro1_data, 0, sizeof(hs_cell_introduce1_data_t));
+
   /* This takes various objects in order to populate the introduce1 data
    * object which is used to build the content of the cell. */
   const node_t *exit_node = build_state_get_exit_node(rend_circ->build_state);