Browse Source

Fix a copy-and-paste issue found by coverity

Fixes CID 980650; bugfix on 0.2.4.10-alpha.
Nick Mathewson 11 years ago
parent
commit
b9432becbe
2 changed files with 5 additions and 1 deletions
  1. 4 0
      changes/cov980650
  2. 1 1
      src/or/routerset.c

+ 4 - 0
changes/cov980650

@@ -0,0 +1,4 @@
+  o Minor bugfixes:
+    - Fix a copy-and-paste error when adding a missing A1 to a routerset
+      because of GeoIPExcludeUnknown. Fix for coverity CID 980650.
+      Bugfix on 0.2.4.10-alpha.

+ 1 - 1
src/or/routerset.c

@@ -255,7 +255,7 @@ routerset_add_unknown_ccs(routerset_t **setp, int only_if_some_cc_set)
   }
   if (add_a1) {
     smartlist_add(set->country_names, tor_strdup("a1"));
-    smartlist_add(set->country_names, tor_strdup("{a1}"));
+    smartlist_add(set->list, tor_strdup("{a1}"));
   }
 
   if (add_unknown || add_a1) {