Make arguments to circuit_set_circid_orconn match the connection that is closing in circuit_about_to_close_connection. This accounts for our mysterious "arbitrary ram gets decremented!" bug.

svn:r5465

src/or/circuituse.c

@@ -516,10 +516,10 @@ circuit_about_to_close_connection(connection_t *conn)
       SMARTLIST_FOREACH(circs, circuit_t *, circ, {
         if (circ->n_conn == conn)
           /* it's closing in front of us */
-          circuit_set_circid_orconn(circ, 0, NULL, P_CONN_CHANGED);
+          circuit_set_circid_orconn(circ, 0, NULL, N_CONN_CHANGED);
         if (circ->p_conn == conn)
           /* it's closing behind us */
-          circuit_set_circid_orconn(circ, 0, NULL, N_CONN_CHANGED);
+          circuit_set_circid_orconn(circ, 0, NULL, P_CONN_CHANGED);
         circuit_mark_for_close(circ);
       });
       smartlist_free(circs);